[PATCH] D40661: Error on -no-define-common if the output is not relocatable

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Driver.cpp:670-671
 
+  if (!Config->Relocatable && !Config->DefineCommon)
+    error("-no-define-common not supported in non relocatable output");
+
----------------
checkOptions is a better place to add this code.


https://reviews.llvm.org/D40661