[PATCH] D40606: [Support/TarWriter] - Don't allow TarWriter to add the same file more than once.

[George Rimar via llvm-commits]

>>  // Append a given file to an archive.
>> -void TarWriter::append(StringRef Path, StringRef Data) {
>> +bool TarWriter::append(StringRef Path, StringRef Data) {
>
>Do you expect any caller doing anything different based on the return
>value? If not I would keep it returning void.
>
>Cheers,
>Rafael

I do not expect it, but it is in LLVM/Support, not in LLD, so can be used not only in linkers,
but anywhere in theory. What is fine for linkers can be error for other apps.
So I just was not sure what we want to do in that case. bool could be a signal to users's code which
could be not aware of the problem.

(I'll change to void in patch update as looks both you and Rui fine with it and I am probably too,
just describing my concerns about that place).

George.