[PATCH] D40632: Add flag to llvm-ar to test GNU64 format more efficently

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: include/llvm/Object/ArchiveWriter.h:41-45
 Error writeArchive(StringRef ArcName, ArrayRef<NewArchiveMember> NewMembers,
                    bool WriteSymtab, object::Archive::Kind Kind,
                    bool Deterministic, bool Thin,
+                   uint64_t CutoffForSym64 = 1ULL << 32,
                    std::unique_ptr<MemoryBuffer> OldArchiveBuf = nullptr);
----------------
Instead of adding a new parameter, can't you just pass K_GNU64 as a kind?


================
Comment at: tools/llvm-ar/llvm-ar.cpp:102
 
+static cl::opt<int> Sym64PowerOfTwo("sym64-power-of-two", cl::Hidden);
+
----------------
and change this to ForceGnu64 or something.


Repository:
  rL LLVM

https://reviews.llvm.org/D40632