[PATCH] D40559: Run Wasm entrypoint on load

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 29 16:42:21 PST 2017


ruiu added a comment.

> I'm not a big fan of having `--entry ''` be the way to disable the entry point.  If we really want to allow that then perhaps --no-entry?   I'm not sure we really need that feature though.  The other linkers all require an entry point I think.

I'd agree. `--dynamic-linker <path>` and `--no-dynamic-linker` are a precedence.

The existing ELF linkers automatically deduce entry point if no -entry option is given. Please look at https://github.com/llvm-project/llvm-project-20170507/blob/master/lld/ELF/Writer.cpp#L1755

That being said, I don't think you want to copy that hacky behavior to a shiny new file format. I'd make -entry mandatory when creating a wasm executable.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D40559





More information about the llvm-commits mailing list