[PATCH] D40482: [X86] Instrument Control Flow For Indirect Branch Tracking

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86TargetMachine.cpp:430
 
+  if (TM->Options.InstrumentControlFlow)
+    addPass(createX86IndirectBranchTrackingPass());
----------------
I believe addPreEmitPass is only called once to build the pass pipeline. We don't rerun it for each function. So I think you're really only checking the command line option here and not the function attribute. So I think that means that this doesn't work from clang.


Repository:
  rL LLVM

https://reviews.llvm.org/D40482