[PATCH] D40420: [CodeGen] Print "%vreg0" as "%0" in both MIR and debug output

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 29 08:15:12 PST 2017


thegameg added inline comments.


================
Comment at: lib/CodeGen/PeepholeOptimizer.cpp:1699
     //
-    // %PHYSREG is the map index; MI is the last valid `%vreg = COPY %PHYSREG`
+    // %PHYSREG is the map index; MI is the last valid `% = COPY %PHYSREG`
     // without any intervening re-definition of %PHYSREG.
----------------
MatzeB wrote:
> maybe use `%[0-9]+` instead of just `%` in the example?
I'l just keep `%vreg = COPY %physreg`.


================
Comment at: lib/Target/AArch64/AArch64InstrInfo.cpp:2833
   //
-  //   %vreg0<def> = COPY %XZR; GPR64common:%vreg0
+  //   %0<def> = COPY %XZR; GPR64common:%0
   //
----------------
MatzeB wrote:
> (unrelated note: Wasn't this renamed to `%xzr` in your other commit?)
Yep. I fixed some of my misses in lib/ and include/ in the commit (r319187).


================
Comment at: lib/Target/BPF/BPFISelDAGToDAG.cpp:549
   unsigned AndOpReg = RegN->getReg();
-  DEBUG(dbgs() << "Examine %vreg" << TargetRegisterInfo::virtReg2Index(AndOpReg)
+  DEBUG(dbgs() << "Examine %" << TargetRegisterInfo::virtReg2Index(AndOpReg)
                << '\n');
----------------
MatzeB wrote:
> Use `printReg()`?
I am using `printReg` here in [[ https://reviews.llvm.org/D40421 | D40421 ]].


https://reviews.llvm.org/D40420





More information about the llvm-commits mailing list