[PATCH] D39508: [ubsan] lit changes for lld testing, future lto testing.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 29 04:10:08 PST 2017


lebedev.ri added inline comments.


================
Comment at: test/lit.common.cfg:345
+config.clang = " " + " ".join(run_wrapper + [config.compile_wrapper, config.clang]) + " "
+config.target_cflags = " " + " ".join(target_cflags + extra_cflags) + " "
----------------
eugenis wrote:
> why not keep target_cflags as a list of strings? Looks like all users are joining them anyway.
Not *all* of them.
There are some places that treat it as a string (via `re.search` e.g.)
So i *think* it is best to keep it as string, not list of strings.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D39508





More information about the llvm-commits mailing list