[PATCH] D40583: Defer StartBackgroundThread() and StopBackgroundThread() in TSan

Dmitry Vyukov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 28 23:54:01 PST 2017


dvyukov added inline comments.


================
Comment at: lib/tsan/rtl/tsan_rtl.h:703
 void Initialize(ThreadState *thr);
+void TSanMaybeSpawnBackgroundThread();
 int Finalize(ThreadState *thr);
----------------
dvyukov wrote:
> Another nit: please don't prefix function in tsan with tsan. Everything here is tsan-something. It does not add any value to add tsan everywhere.
And this all is already in `__tsan` namespace. So this is actually `tsan's __tsan::TSan...`


Repository:
  rL LLVM

https://reviews.llvm.org/D40583





More information about the llvm-commits mailing list