[PATCH] D40558: [ELF] - Trigger error when -R <filename> is given.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 28 14:07:19 PST 2017


Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:

> ruiu added a comment.
>
> If you are suggesting we emit something like "cannot open file for -R: foo/bar is a directory. Did you mean -rpath?" for -R, I think I'd agree that that is probably better than just emitting an error without the hint.

Two options:
* We alias -R to --just-symbols. In which case an error like what you
  are suggesting is OK.
* We alias -R to --rpath. In which case we would like an error like:
  "foo/bar is not a directory. Do you want --just-symbols?".

Given that --rpath is more common, I think we should keep -R aliased to
--rpath and have the second error.

Cheers,
Rafael


More information about the llvm-commits mailing list