[PATCH] D38722: Added Remarks for Loop Versioning LICM Pass

[Evgeny Astigeevich via Phabricator via llvm-commits]

eastig added inline comments.


================
Comment at: lib/Transforms/Scalar/LoopVersioningLICM.cpp:507-511
+    ORE->emit([&]() {
+        return OptimizationRemarkMissed(DEBUG_TYPE, "IllegalLoopMemoryAccess",
+                                 CurLoop->getStartLoc(), CurLoop->getHeader())
+        << " Illegal Loop memory access";
+    });
----------------
Deepak_Porwal wrote:
> eastig wrote:
> > Maybe legalLoopMemoryAccesses should emit remarks?
> It's difficult to emit remark from legalLoopMemoryAccesses as we don't have current loop info.
> It's difficult to emit remark from legalLoopMemoryAccesses as we don't have current loop info.

Sorry, don't follow. 'legalLoopMemoryAccesses' is a member function. It has the same access to CurLoop as isLegalForVersioning.


Repository:
  rL LLVM

https://reviews.llvm.org/D38722