[PATCH] D39114: [XRay][compiler-rt][Darwin] Minimal XRay build support in Darwin

Jonas Hahnfeld via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 28 13:00:39 PST 2017


Hahnfeld added a comment.

I'm getting "multiple definition" errors on powerpc64le when linking the unit tests, for example `XRayBufferQueueTest`:

  src/projects/compiler-rt/lib/xray/xray_utils.cc:34: multiple definition of `__xray::retryingWriteAll(int, char*, char*)'
  src/projects/compiler-rt/lib/xray/xray_utils.cc:73: multiple definition of `__xray::readValueFromFile(char const*, long long*)'
  src/projects/compiler-rt/lib/xray/xray_utils.cc:95: multiple definition of `__xray::getLogFD()'

to name a few of the errors.

(related note: Why aren't the unit tests rebuilt if the `libclang_rt.xray-powerpc64le.a` changes?!? After reverting this commit locally for testing, the unit test built just fine. After reapplying the test wasn't rebuilt and I saw no problems...)


https://reviews.llvm.org/D39114





More information about the llvm-commits mailing list