[PATCH] D40335: [WIP] X86-specific path: Implemented the fusing of MUL+SUBADD to FMSUBADD

Dmitry Venikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 28 04:34:29 PST 2017


Quolyk added a comment.

In https://reviews.llvm.org/D40335#935081, @craig.topper wrote:

> Is this really testing both ways of doing this? There's one from shuffles and one from build_vector.
>
> According to the coverage build bot, the build_vector path of fmaddsub isn't tested today.
>
> http://lab.llvm.org:8080/coverage/coverage-reports/llvm/coverage/Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/lib/Target/X86/X86ISelLowering.cpp.html#L7505


Lol, I added inline comment to that code, but didn't submit comment. Indeed, this isn't tested and I don't know how to do it.


https://reviews.llvm.org/D40335





More information about the llvm-commits mailing list