[PATCH] D40360: [AArch64][SVE] Asm: Add SVE predicate register definitions and parsing support

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 28 03:30:28 PST 2017


sdesmalen added inline comments.


================
Comment at: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:4422
+                   "sve predicate register without type specifier expected");
+  }
+
----------------
efriedma wrote:
> Testcase?  (It looks like it should be possible to test this part even without any actual SVE instructions which take a predicate operand.)
Well spotted, thanks! I've added two test files (test/MC/AArch64/SVE/dot-req.s and test/MC/AArch64/SVE/dot-req-diagnostics.s) which also test the SVE data vector variant.


https://reviews.llvm.org/D40360





More information about the llvm-commits mailing list