[PATCH] D40512: [Debugify] Add a pass to test debug info preservation

Mandeep Singh Grang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 27 16:10:01 PST 2017


mgrang added inline comments.


================
Comment at: lib/Transforms/Utils/Debugify.cpp:162
+      unsigned VarNum;
+      bool Valid = to_integer(DVI->getVariable()->getName(), VarNum, 10);
+      assert(Valid && "Unexpected name for DILocalVariable");
----------------
How about you wrap the "bool Valid" definition and the assert inside #ifndef NDEBUG ? You can then get rid of the (void) Valid.


https://reviews.llvm.org/D40512





More information about the llvm-commits mailing list