[PATCH] D40328: Use a single file name to represent a lock

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 27 13:33:45 PST 2017


rnk added a comment.

I just assume that LockFileManager doesn't actually work on Windows. It's really only used by implicit modules, and we're pushing people away from those anyway. If we don't need this for the TempFile migration, I say let sleeping broken code lie, unless you think this simplification is worth it for Posix systems.


https://reviews.llvm.org/D40328





More information about the llvm-commits mailing list