[PATCH] D40304: [InstCombine] PR35354: Convert load bitcast (select (Cond, &V1, &V2)) --> select(Cond, load bitcast &V1, load bitcast &V2)

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 27 12:50:48 PST 2017


ABataev added a comment.

In https://reviews.llvm.org/D40304#936527, @spatel wrote:

> In https://reviews.llvm.org/D40304#936522, @dberlin wrote:
>
> > Otherwise, the only way around this is to not canonicalize to select this way that early.
>
>
> And for reference, I have a patch towards that - https://reviews.llvm.org/D38566.
>
> There may be other fixes needed to solve PR35354 (sorry for missing that in the title!)


Your patch fixes SimplifyCFG pass, but canonicalization is occurred in InstCombiner (see combineLoadToOperationType function)


https://reviews.llvm.org/D40304





More information about the llvm-commits mailing list