[PATCH] D37989: InstCombine: Insert missing canonicalizes

escha via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 27 11:42:12 PST 2017


escha added a comment.

Even if they're not redundant, it's something we still don't want.

For example: imagine a function that takes two input texture reads, takes the max, and stores that. On our arch, that wouldn't canonicalize, so we would be forced to insert an additional arithmetic instruction for every single "max", doubling the amount of math in the function.


https://reviews.llvm.org/D37989





More information about the llvm-commits mailing list