[PATCH] D40317: [llvm-dwarfdump] Display DW_AT_high_pc as absolute value

[David Blaikie via llvm-commits]

On Mon, Nov 27, 2017 at 8:11 AM Paul Robinson via Phabricator <
reviews at reviews.llvm.org> wrote:

> probinson added inline comments.
>
>
> ================
> Comment at: lib/DebugInfo/DWARF/DWARFDie.cpp:241
> +    uint64_t LowPC, HighPC, Index;
> +    if (Die.getLowAndHighPC(LowPC, HighPC, Index))
> +      OS << format("0x%016" PRIx64, HighPC);
> ----------------
> dblaikie wrote:
> > It seems unfortunate that this searches for the low pc when we already
> have the form/attribute in formValue.
> >
> > What happens if a buggy DIE has two LowPCs? This might erroneously print
> the same one twice? (I assume DWARF supports, in general, multiple
> instances of the same attribute in a DIE? or is that buggy enough to have
> been detected earlier?)
> You can't repeat the same attribute in the same DIE, that's invalid
> DWARF.  I don't know whether the verifier checks for that.
>

Ah, rightio - well, just a (likely quite minor) perf issue then. Thanks for
clarifying :)


>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D40317
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171127/9c8e006c/attachment.html>