[PATCH] D39910: [ARM] Issue an eror when non-general-purpose registers used in address operands (alternative)

Oliver Stannard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 27 07:05:42 PST 2017


olista01 added a comment.

This patch doesn't have full context (git diff -U999999), please use that in future as it makes reviewing easier.



================
Comment at: test/MC/ARM/arm-reg-addr-errors.s:1
+@ RUN: not llvm-mc -triple=armv7a-eabi < %s 2>&1 | FileCheck %s
+
----------------
The previous version of this patch also tested Thumb, and FP/SIMD loads and stores. The code change looks like it should still affect those (except for the diagnostic strings), so could those tests also be kept?


https://reviews.llvm.org/D39910





More information about the llvm-commits mailing list