[PATCH] D39595: [DAGCombine] Refactor ReduceLoadWidth

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

Thanks Sam, looks good to me. Please wait a day or two with committing, to give others a chance to raise additional concerns.



================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:8034
+    VT = HasAnyExt ? LN0->getValueType(0) : VT;
+    if (!isAndLoadExtLoad(N1C, LN0, VT, ExtVT, LoadedVT, NarrowLoad))
+      return SDValue();
----------------
IIRC your first version of the patch removed to unneeded LoadedVT argument.  I think this would be a worthwhile simplification to get in as NFC independently.


https://reviews.llvm.org/D39595