[PATCH] D38133: [CGP] Make optimizeMemoryInst able to combine more kinds of ExtAddrMode fields

[John Brawn via Phabricator via llvm-commits]

john.brawn added a comment.

> Unfortunately I still have problems enabling the optimization by default. It causes build bot hangs-up, I'm evaluating the failures.
>  If you can also look into it, would be great.

I've done some testing and there appears to be a problem with how isTrivial handles null pointers, I'll post a patch for that shortly.

> Anyway, I think you can land this patch with all options off be default. Then I will switch them on one by one resolving different issues.

DisableComplexAddrModes already disables everything, so I don't think there's a need to disable the various AddrSinkCombine options for now. We can disable individual ones when DisableComplexAddrModes is turned on, if we need to.


Repository:
  rL LLVM

https://reviews.llvm.org/D38133