[PATCH] D39114: [XRay][darwin] Initial XRay in Darwin Support

Kamil Rytarowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 23 23:14:37 PST 2017


krytarowski added inline comments.


================
Comment at: compiler-rt/lib/xray/xray_x86_64.cc:25
+  size_t Len = 0;
+  if (sysctlbyname("hw.cpufrequency_max", &CPUFreq, &Len, NULL, 0) == -1) {
+    Report("Unable to determine CPU frequency for TSC accounting; errno = %d\n",
----------------
Is it OK for you to call here internally malloc(3)? At least the NetBSD version calls it.


https://reviews.llvm.org/D39114





More information about the llvm-commits mailing list