[lld] r318937 - Make a test stricter.

Rafael Espindola via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 23 15:40:34 PST 2017


Author: rafael
Date: Thu Nov 23 15:40:33 2017
New Revision: 318937

URL: http://llvm.org/viewvc/llvm-project?rev=318937&view=rev
Log:
Make a test stricter.

It now has a DT_NEEDED that could be removed by --gc-sections and one
that cannot. Without this all tests would pass if --gc-sections just
removed all DT_NEEDED.

Added:
    lld/trunk/test/ELF/Inputs/gc-sections-shared.s
Modified:
    lld/trunk/test/ELF/gc-sections-shared.s

Added: lld/trunk/test/ELF/Inputs/gc-sections-shared.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/Inputs/gc-sections-shared.s?rev=318937&view=auto
==============================================================================
--- lld/trunk/test/ELF/Inputs/gc-sections-shared.s (added)
+++ lld/trunk/test/ELF/Inputs/gc-sections-shared.s Thu Nov 23 15:40:33 2017
@@ -0,0 +1,3 @@
+.global baz
+.type baz, @function
+baz:

Modified: lld/trunk/test/ELF/gc-sections-shared.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/gc-sections-shared.s?rev=318937&r1=318936&r2=318937&view=diff
==============================================================================
--- lld/trunk/test/ELF/gc-sections-shared.s (original)
+++ lld/trunk/test/ELF/gc-sections-shared.s Thu Nov 23 15:40:33 2017
@@ -1,8 +1,10 @@
 # REQUIRES: x86
 # RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %p/Inputs/shared.s -o %t2.o
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %p/Inputs/gc-sections-shared.s -o %t3.o
 # RUN: ld.lld -shared %t2.o -o %t2.so
+# RUN: ld.lld -shared %t3.o -o %t3.so
 # RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
-# RUN: ld.lld --gc-sections --export-dynamic-symbol foo -o %t %t.o --as-needed %t2.so
+# RUN: ld.lld --gc-sections --export-dynamic-symbol foo -o %t %t.o --as-needed %t2.so %t3.so
 # RUN: llvm-readobj --dynamic-table --dyn-symbols %t | FileCheck %s
 
 # This test the property that we have a needed line for every undefined.
@@ -45,9 +47,21 @@
 # CHECK-NEXT:     Other:
 # CHECK-NEXT:     Section: .text
 # CHECK-NEXT:   }
+# CHECK-NEXT:   Symbol {
+# CHECK-NEXT:     Name: baz
+# CHECK-NEXT:     Value:
+# CHECK-NEXT:     Size:
+# CHECK-NEXT:     Binding: Global
+# CHECK-NEXT:     Type:
+# CHECK-NEXT:     Other:
+# CHECK-NEXT:     Section: Undefined
+# CHECK-NEXT:   }
 # CHECK-NEXT: ]
 
-# CHECK: NEEDED Shared library: [{{.*}}.so]
+# CHECK-NOT: NEEDED
+# CHECK:     NEEDED Shared library: [{{.*}}2.so]
+# CHECK:     NEEDED Shared library: [{{.*}}3.so]
+# CHECK-NOT: NEEDED
 
 .section .text.foo, "ax"
 .globl foo
@@ -62,6 +76,7 @@ ret
 .section .text._start, "ax"
 .globl _start
 _start:
+call baz
 ret
 
 .section .text.unused, "ax"




More information about the llvm-commits mailing list