[PATCH] D40253: [ELF] Make tests with undefined symbols more explicit.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 23 12:00:03 PST 2017


I think that the tests not depending on a lld idiosyncrasy is an
independent improvement.

It would also make it easier to review D38790.

Cheers,
Rafael

Igor Kudrin <ikudrin at accesssoftek.com> writes:

> As the main reason for this patch was to make existing tests compatible with the patch to remove dead symbols, https://reviews.llvm.org/D38790, I was going to commit them in sequence. This way the commit history will be more smooth and understandable.
>
> Best Regards,
> Igor Kudrin
> C++ Developer, Access Softek, Inc.
>
> ________________________________________
> From: Rafael Avila de Espindola <rafael.espindola at gmail.com>
> Sent: Wednesday, November 22, 2017 11:48 PM
> To: reviews+D40253+public+c3029adef1cd20a3 at reviews.llvm.org; Igor Kudrin; ruiu at google.com
> Cc: emaste at freebsd.org; llvm-commits at lists.llvm.org; arichardson.kde at gmail.com; adhemerval.zanella at linaro.org
> Subject: Re: [PATCH] D40253: [ELF] Make tests with undefined symbols more explicit.
>
> Is anything else blocking this patch?
>
> Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:
>
>> ruiu accepted this revision.
>> ruiu added a comment.
>> This revision is now accepted and ready to land.
>>
>> LGTM
>>
>>
>> Repository:
>>   rL LLVM
>>
>> https://reviews.llvm.org/D40253


More information about the llvm-commits mailing list