[PATCH] D40249: Copy Function's calling convention by default when creating a new Call

serge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 23 04:46:16 PST 2017


serge-sans-paille added a comment.

@rnk: I've implemented the extra CallingConvention argument in the various create statements, but I'm very unhappy with the result: it requires a lot of extra create overload, the number of optional arguments grows and the overall gain within the actual codebase is small. I honestly think my current proposal, even if modest, is already a good step forward.

As an argument, consider the fact that this patch removes 41 lines of mostly redundant code.


Repository:
  rL LLVM

https://reviews.llvm.org/D40249





More information about the llvm-commits mailing list