[PATCH] D40002: [RISCV] MC layer support for the jump/branch instructions of standard compress instruction set

Shiva Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 22 23:38:14 PST 2017


shiva0217 added inline comments.


================
Comment at: lib/Target/RISCV/RISCVInstrInfoC.td:118
+         "c.jalr", "$rs1">;
+
+let hasSideEffects = 0, mayLoad = 0, mayStore = 0 in
----------------
asb wrote:
> Given that Jump_imm, Call_Imm, Jump_Reg and Call_Reg only have a single instruction in that class, I think it makes sense to drop the intermediate classes and just define the instructions directly.
Remove Jump_imm, Call_Imm, Jump_Reg and Call_Reg only have a single instruction in that class and define the instruction directly.


Repository:
  rL LLVM

https://reviews.llvm.org/D40002





More information about the llvm-commits mailing list