[llvm] r318361 - Convert a use of createUniqueFile to TempFile::create.

[Rafael Avila de Espindola via llvm-commits]

Davide Italiano <davide at freebsd.org> writes:

> On Wed, Nov 22, 2017 at 12:03 PM, Rafael Avila de Espindola via
> llvm-commits <llvm-commits at lists.llvm.org> wrote:
>> Should be fixed now. Thanks a lot for the bug report.
>>
>> Cheers,
>> Rafael
>>
>
> Any chance we can have some regression testing for this (even if
> enabled only on Windows?)

It depends.

The issue in bugpoint was that it was calling discard twice. Given the
design of TempFile, that should work.

One patch fixed TempFile and that included a unit test. With that change
the code in bugpoint became just redundant and I removed it in a
followup.

If the issue is testing bugpont itself on windows, we need to have
passes that crash so that bugpoint can be tested. On unix we do that by
having opt load BugpointPasses.so. On windows we would need to have an
option to link those passes into opt.

Cheers,
Rafael