[PATCH] D40369: Support sext, zext and trunc instructions in SCEV delinearization algorithm (new revision)

[Eli Friedman via Phabricator via llvm-commits]

efriedma added reviewers: zinob, efriedma.
efriedma added a comment.

Please post patches with full context (http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface)

Missing unit-tests.

Please put the rename into a separate patch; it makes the functional changes more difficult to review.

I don't think you can "ignore" all these operations like this; I mean, I can see ignoring sign-extension because it's signed division, but zero-extension or truncation actually changes the result.  (4294967300/4294967298 is very different from 4/2.)


https://reviews.llvm.org/D40369