[PATCH] D39346: [LV] [ScalarEvolution] Fix PR34965 - Cache pointer stride information before LV code gen

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 22 10:25:26 PST 2017


rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.

Hi Diego,

Ok, I agree with Hideki that caching is good as well as re-evaluating and making sure that we don't degrade. However, as you both said, detecting degradation will require SCEV to go beyond its current design and new cases in the vectoriser we don't have yet.

>From that point of view, I agree with Hideki that this can be a baby-step towards a better model, so the patch would be ok for now.

Can you please add some comments to `collectIsConsecutivePtr` to reflect that? Otherwise, LGTM. Thanks!


https://reviews.llvm.org/D39346





More information about the llvm-commits mailing list