[PATCH] D40219: [CMake] Add LLVM_ENABLE_IDE option to better process sources for IDE's

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

Looks good to me, but i have no prior involvement in llvm cmake build system so i'm not sure i can/should Accept this Revision.



================
Comment at: cmake/modules/HandleLLVMOptions.cmake:836
+set(LLVM_ENABLE_IDE_default OFF)
+if (XCODE OR MSVC_IDE OR CMAKE_EXTRA_GENERATOR)
+  set(LLVM_ENABLE_IDE_default ON)
----------------
When using qtcreator, which results in extra generator being used, the `LLVM_ENABLE_IDE` option is correctly default-on, which is great.


================
Comment at: cmake/modules/LLVMProcessSources.cmake:55
   llvm_check_source_file_list( ${sources} )
-  if( MSVC_IDE OR XCODE )
+  if( MSVC_IDE OR XCODE OR LLVM_ENABLE_IDE )
     # This adds .td and .h files to the Visual Studio solution:
----------------
Or do we want to **rely** on `LLVM_ENABLE_IDE`?


https://reviews.llvm.org/D40219