[PATCH] D40291: [Support] Add WritableMemoryBuffer class

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 21 10:06:02 PST 2017


Zachary Turner <zturner at google.com> writes:

> A MutableMemoryBuffer need not be backed by mmap.  For example, you could
> just allocate some scratch bytes from the heap.  Allowing something like
> this to work with the same interface as an mmap is one of the primary
> advantages IMO, because it means you don't have to have different code
> paths for mmap and malloc.

I agree. What about RequiresNullTerminator and IsVolatile? Do you need
to expose them?

Cheers,
Rafael


More information about the llvm-commits mailing list