[PATCH] D35625: Removal of microMIPS64R6

Simon Dardis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 21 08:16:47 PST 2017


sdardis added a comment.

  .set  micromips
  .set  arch=mips64r6
  nop

covers the parseSetArchDirective case.



================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:516
+
+    if (sti.getCPU() == "mips64r6" && inMicroMipsMode())
+      report_fatal_error("microMIPS64R6 is not supported", false);
----------------
Don't use STI directly here, use getSTI() instead.


================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:7154
   } else if (Tok.getString() == "mips64r6") {
     return parseSetFeature(Mips::FeatureMips64r6);
   } else if (Tok.getString() == "dsp") {
----------------
Check here if the assembler is in micromips mode.


https://reviews.llvm.org/D35625





More information about the llvm-commits mailing list