[llvm] r318747 - [ARM GlobalISel] Add comment for r318398. NFC.

Diana Picus via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 21 02:17:02 PST 2017


Author: rovka
Date: Tue Nov 21 02:17:02 2017
New Revision: 318747

URL: http://llvm.org/viewvc/llvm-project?rev=318747&view=rev
Log:
[ARM GlobalISel] Add comment for r318398. NFC.

Mention the purpose of the BICri tests added by r318398, as requested in
post-commit review.

Modified:
    llvm/trunk/test/CodeGen/ARM/GlobalISel/arm-instruction-select-combos.mir

Modified: llvm/trunk/test/CodeGen/ARM/GlobalISel/arm-instruction-select-combos.mir
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/GlobalISel/arm-instruction-select-combos.mir?rev=318747&r1=318746&r2=318747&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/ARM/GlobalISel/arm-instruction-select-combos.mir (original)
+++ llvm/trunk/test/CodeGen/ARM/GlobalISel/arm-instruction-select-combos.mir Tue Nov 21 02:17:02 2017
@@ -461,6 +461,11 @@ body:             |
     %0(s32) = COPY %r0
     ; CHECK: [[VREGX:%[0-9]+]]:gpr = COPY %r0
 
+    ; This test and the following ones are a bit contrived, since they use a
+    ; G_XOR that can be constant-folded. They exist mostly to validate the
+    ; TableGen pattern that defines BICri. We also have a pattern for matching a
+    ; G_AND with a G_CONSTANT operand directly, which is the more common case,
+    ; but that will be covered by different tests.
     %1(s32) = G_CONSTANT i32 192
 
     %2(s32) = G_CONSTANT i32 -1




More information about the llvm-commits mailing list