[PATCH] D39526: [XRay] Use optimistic logging model for FDR mode

[Martin Pelikán via Phabricator via llvm-commits]

pelikan accepted this revision.
pelikan added inline comments.
This revision is now accepted and ready to land.


================
Comment at: compiler-rt/lib/xray/xray_fdr_logging_impl.h:316-317
 
-static inline void writeFunctionRecord(int FuncId, uint32_t TSCDelta,
-                                       XRayEntryType EntryType,
-                                       char *&MemPtr) XRAY_NEVER_INSTRUMENT {
+static inline void
+writeFunctionRecord(int FuncId, uint32_t TSCDelta,
+                    XRayEntryType EntryType) XRAY_NEVER_INSTRUMENT {
----------------
dberris wrote:
> pelikan wrote:
> > Plus million for this coding style.  Much better than wrapping in the middle of the screen.
> Thank clang-format -- this only happened because we removed the `MemPtr` argument.
It didn't do that before, and I *really* tried to make it.


https://reviews.llvm.org/D39526