[PATCH] D40156: Fix recursive attribute fetching in DWARFDie

[David Blaikie via llvm-commits]

Would be interesting (though not necessary, as such) to know what situation
this comes up so we can keep it in mind when figuring out what to
support/or not.

but also, if it's only produced due to a bug, I'm not sure how important it
would be to support the pass-through behavior being changed here. The DWARF
is still dumped correctly & the absence of the pass-through name lookup
wouldn't make diagnosing the bug any more difficult, etc.

- Dave

On Mon, Nov 20, 2017 at 1:33 PM Greg Clayton <clayborg at gmail.com> wrote:

> I don't have access to the exact source. I was working with an ELF file
> that was given to me. The source path seems to indicate it was from open
> source and it had a version on it:
> 0.3.2_fb/src/glog-0.3.2/src/vlog_is_on.cc
>
> Knowing this does happen in the wild means we need to fix it regardless,
> no?
>
>
> On Nov 20, 2017, at 1:18 PM, David Blaikie <dblaikie at gmail.com> wrote:
>
> Any chance of an original source example?
>
> On Mon, Nov 20, 2017 at 7:46 AM Greg Clayton via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
>> clayborg added a comment.
>>
>> Ping
>>
>>
>> Repository:
>>   rL LLVM
>>
>> https://reviews.llvm.org/D40156
>>
>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171120/8849eb9e/attachment.html>