[PATCH] D40240: Garbage-collected symbols shouldn't make DSOs alive.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 20 11:34:01 PST 2017


One more thing:

>-      if (!S->isWeak())
>-        File->IsUsed = true;
>+      if (!Config->GcSections && !S->isWeak())
>+        File->IsNeeded = true;

Please leave the GcSections check for the next patch. That way this
patch is just a cleanup on how we compute IsNeeded.

It is probably OK with that, but pleas upload an updated version for a
final check.

Thanks,
Rafael


More information about the llvm-commits mailing list