[PATCH] D40051: AMDGPU: Rename Bonaire target to be gfx704; update target feature handling

[Konstantin Zhuravlyov via Phabricator via llvm-commits]

kzhuravl added inline comments.


================
Comment at: docs/AMDGPUUsage.rst:126
+     -----------------------------------------------------------------------------------
+     ``gfx700``  - ``kaveri``    ``amdgcn``   APU                     - A6-7000
+                                                                      - A6 Pro-7050B
----------------
Should this APU have an xnack on by default? I remember we talked about defaulting xnack to on for all APUs.


================
Comment at: docs/AMDGPUUsage.rst:144
+                                                                      - Radeon R390x
+     ``gfx703``  - ``kabini``    ``amdgcn``   APU                     - E1-2100
+                 - ``mullins``                                        - E1-2200
----------------
Should this APU have an xnack on by default? I remember we talked about defaulting xnack to on for all APUs.


================
Comment at: docs/AMDGPUUsage.rst:523-528
+     ``EF_AMDGPU_XNACK``               0x00000100 Indicates if the ``xnack``
+                                                  target feature is
+                                                  enabled for all code
+                                                  contained in the code object.
+                                                  See
+                                                  :ref:`amdgpu-target-features`.
----------------
Should we mention anything about the fact that we will not link code objects with different xnack settings?


https://reviews.llvm.org/D40051