[PATCH] D40002: [RISCV] MC layer support for the jump/branch instructions of standard compress instruction set

Shiva Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 19 22:11:07 PST 2017


shiva0217 added inline comments.


================
Comment at: lib/Target/RISCV/MCTargetDesc/RISCVAsmBackend.cpp:194
+  }
+  return 4;
+}
----------------
mgrang wrote:
> This return is unneeded as the default case is handled.
Remove redundant return.


================
Comment at: lib/Target/RISCV/MCTargetDesc/RISCVFixupKinds.h:39
+  // fixup_riscv_rvc_jump - 11-bit fixup for symbol references in the
+  // compressed instruction
+  fixup_riscv_rvc_jump,
----------------
apazos wrote:
> compressed jump instruction
Fixup comments.


Repository:
  rL LLVM

https://reviews.llvm.org/D40002





More information about the llvm-commits mailing list