[PATCH] D38894: [RFC][Tablegen] Add CCIfSplitFrom and CCPassIndirectBySamePointer Calling Convention Interfaces

[Shiva Chen via Phabricator via llvm-commits]

shiva0217 added inline comments.


================
Comment at: include/llvm/CodeGen/CallingConvLower.h:263
 
+  CCValAssign lastLoc(void) {
+    return Locs.back();
----------------
mgrang wrote:
> Can you leave out the void from the empty parameter type?
Remove void from empty parameter type as @mgrang suggest.


================
Comment at: test/CodeGen/SystemZ/args-11.ll:16
+; CHECK:	la	%r2, 160(%r15)
+; CHECK:        brasl	%r14, __floatuntisf at PLT
+  %1 = load i128, i128* @a, align 16
----------------
mgrang wrote:
> Check indentation.
Fix indentation.


https://reviews.llvm.org/D38894