[llvm] r318571 - [CMake][runtimes] Don't passthrough prefixes for non-default targets

Petr Hosek via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 17 15:51:53 PST 2017


Author: phosek
Date: Fri Nov 17 15:51:53 2017
New Revision: 318571

URL: http://llvm.org/viewvc/llvm-project?rev=318571&view=rev
Log:
[CMake][runtimes] Don't passthrough prefixes for non-default targets

The passthrough is useful for setting up the options for the default
build, but we already have a different mechanism to pass CMake flags
to builds for builtins and runtimes targets so this is not really
needed there. Furthermore, when the flags are set for the default
build, with the prefix passthrough set we have to explicitly override
all options in other targets which can be cumbersome.

Differential Revision: https://reviews.llvm.org/D39988

Modified:
    llvm/trunk/runtimes/CMakeLists.txt

Modified: llvm/trunk/runtimes/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/runtimes/CMakeLists.txt?rev=318571&r1=318570&r2=318571&view=diff
==============================================================================
--- llvm/trunk/runtimes/CMakeLists.txt (original)
+++ llvm/trunk/runtimes/CMakeLists.txt Fri Nov 17 15:51:53 2017
@@ -247,7 +247,6 @@ else() # if this is included from LLVM's
                                         -DCOMPILER_RT_DEFAULT_TARGET_ONLY=ON
                                         ${${target}_extra_args}
                              TOOLCHAIN_TOOLS clang lld llvm-ar llvm-ranlib
-                             PASSTHROUGH_PREFIXES COMPILER_RT
                              USE_TOOLCHAIN
                              ${EXTRA_ARGS})
   endfunction()




More information about the llvm-commits mailing list