[PATCH] D40184: [LICM] Fix PR35342

Jun Bum Lim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 17 12:40:21 PST 2017


This revision was automatically updated to reflect the committed changes.
junbuml marked an inline comment as done.
Closed by commit rL318551: [LICM] Fix PR35342 (authored by junbuml).

Changed prior to commit:
  https://reviews.llvm.org/D40184?vs=123396&id=123397#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D40184

Files:
  llvm/trunk/lib/Transforms/Scalar/LICM.cpp
  llvm/trunk/test/Transforms/LICM/pr35342.ll


Index: llvm/trunk/test/Transforms/LICM/pr35342.ll
===================================================================
--- llvm/trunk/test/Transforms/LICM/pr35342.ll
+++ llvm/trunk/test/Transforms/LICM/pr35342.ll
@@ -0,0 +1,26 @@
+; RUN: opt -licm -S < %s | FileCheck %s
+
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128-ni:1"
+target triple = "x86_64-unknown-linux-gnu"
+
+; CHECK-LABEL: @f1
+; CHECK-LABEL: bci_524:
+; CHECK: add i32 undef, undef
+define void @f1(i32 %v) {
+not_zero.lr.ph:
+  br label %not_zero
+
+not_zero:
+  br i1 undef, label %bci_748 ,  label %bci_314
+
+bci_314:
+  %0 = select i1 undef, i32 undef, i32 undef
+  br label %not_zero
+
+bci_524:                   ; No predecessors!
+  %add = add i32 %0, %0
+  br label %bci_748
+
+bci_748:
+  ret void
+}
Index: llvm/trunk/lib/Transforms/Scalar/LICM.cpp
===================================================================
--- llvm/trunk/lib/Transforms/Scalar/LICM.cpp
+++ llvm/trunk/lib/Transforms/Scalar/LICM.cpp
@@ -906,7 +906,7 @@
       continue;
 
     if (!DT->isReachableFromEntry(User->getParent())) {
-      User->replaceUsesOfWith(&I, UndefValue::get(I.getType()));
+      U = UndefValue::get(I.getType());
       continue;
     }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D40184.123397.patch
Type: text/x-patch
Size: 1228 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171117/6180db0c/attachment.bin>


More information about the llvm-commits mailing list