[PATCH] D39949: [CMake][libcxxabi] Support merging archives when statically linking unwinder

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 17 09:25:05 PST 2017


beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.

One small nitpick, otherwise LGTM!



================
Comment at: src/CMakeLists.txt:157
+    if (TARGET unwind_static OR HAVE_LIBUNWIND)
+      set(cxxabi_static_sources ${cxxabi_static_sources} $<TARGET_OBJECTS:unwind_objects>)
+    endif()
----------------
You should be able to do this with `list(APPEND ...)` instead of set.


Repository:
  rL LLVM

https://reviews.llvm.org/D39949





More information about the llvm-commits mailing list