[PATCH] D40159: Make TLS/NetBSD handling more generic

Joerg Sonnenberger via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 17 07:10:27 PST 2017


joerg added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_linux_libcdep.cc:347
+# else
+#  error "unsupported CPU arch"
+# endif
----------------
The fallback is just using _lwp_getprivate() directly. No need to error out.


================
Comment at: lib/sanitizer_common/sanitizer_linux_libcdep.cc:404
+# endif
+  }
 #elif SANITIZER_ANDROID
----------------
What is this code trying to do in first place? It doesn't really make sense to me. Handling variant I and II differently doesn't make sense either.


Repository:
  rL LLVM

https://reviews.llvm.org/D40159





More information about the llvm-commits mailing list