[PATCH] D40125: [ELF] Fix rewriting of --sysroot in reproducer tars

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 17 06:04:02 PST 2017


arichardson marked 2 inline comments as done.
arichardson added inline comments.


================
Comment at: ELF/DriverUtils.cpp:163
     case OPT_symbol_ordering_file:
     case OPT_version_script:
       OS << Arg->getSpelling() << " " << quote(rewritePath(Arg->getValue()))
----------------
ruiu wrote:
> Can't you just add `case OPT_sysroot` here?
Indeed, that's much better. I didn't realize that lld also accepts `--sysroot` without the equals


https://reviews.llvm.org/D40125





More information about the llvm-commits mailing list