[PATCH] D40124: A new sched model for SHLD/SHRD

Andrew V. Tischenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 17 03:01:23 PST 2017


avt77 added a comment.

In https://reviews.llvm.org/D40124#928414, @RKSimon wrote:

> schedule-x86-64-shld.ll is superfluous - please remove it


In fact I use it to show and check code patterns:

  shldrri <-> shl+shr+lea

or

  shldrrCL <-> mov+shr+mov+sub+....

I was planning to extend it with other possible variants.
Of course if you insist I could keep it localy but from my point of view the test could be useful for others. I could remove several RUN lines and leave one or two of them only if you'd like.
Should I remove/update the test?


https://reviews.llvm.org/D40124





More information about the llvm-commits mailing list