[PATCH] D40061: [WIP] [ARM] Make MachineVerifier more strict about terminators

Mikael Holmén via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 17 01:21:50 PST 2017


uabelho added a comment.

So now you make all returns (predicated or not) non-analyzable from analyzeBranch's perspective?

Do you know if all targets follow this? I suppose all tests under test/ still pass with the stricter
verifier checks, but have you looked at the different analyzeBranch implementations?

I think the change makes sense but I also know that fiddling with analyzeBranch can have
unexpected consequences so it's very hard to really know if it works or not.


Repository:
  rL LLVM

https://reviews.llvm.org/D40061





More information about the llvm-commits mailing list