[compiler-rt] r317852 - [libFuzzer] trying to make sigusr tests more reliable

Matt Morehouse via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 16 15:11:42 PST 2017


Problem with merge-sigusr.test is Mac's pkill requires the signal flag to
come before other options.  Should be fixed in r318465.

But I noticed merge.test is failing on my Linux machine at ToT.  Kostya,
are you aware of this issue?

On Wed, Nov 15, 2017 at 8:53 PM, Kostya Serebryany <kcc at google.com> wrote:

> r318376 disables the test on Mac.
> Matt, please take a look when you have a chance.
> Most likely "pkill" is not present on Mac bots, or some such.
> Geroge: FYI
>
> On Wed, Nov 15, 2017 at 8:42 PM, Akira Hatanaka <ahatanak at gmail.com>
> wrote:
>
>> I just found out about this today, but this bot has been failing since
>> r317829:
>>
>> http://green.lab.llvm.org/green/job/libFuzzer/
>>
>> The test that is currently failing is merge-sigusr.test.
>>
>> Can you take a look please?
>>
>>
>> On Thu, Nov 9, 2017 at 4:26 PM, Kostya Serebryany via llvm-commits <
>> llvm-commits at lists.llvm.org> wrote:
>>
>>> Author: kcc
>>> Date: Thu Nov  9 16:26:23 2017
>>> New Revision: 317852
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=317852&view=rev
>>> Log:
>>> [libFuzzer] trying to make sigusr tests more reliable
>>>
>>> Modified:
>>>     compiler-rt/trunk/test/fuzzer/merge-sigusr.test
>>>     compiler-rt/trunk/test/fuzzer/sigusr.test
>>>
>>> Modified: compiler-rt/trunk/test/fuzzer/merge-sigusr.test
>>> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/f
>>> uzzer/merge-sigusr.test?rev=317852&r1=317851&r2=317852&view=diff
>>> ============================================================
>>> ==================
>>> --- compiler-rt/trunk/test/fuzzer/merge-sigusr.test (original)
>>> +++ compiler-rt/trunk/test/fuzzer/merge-sigusr.test Thu Nov  9 16:26:23
>>> 2017
>>> @@ -15,6 +15,7 @@ RUN: echo g > %t/C2/g
>>>  RUN: %t/LFSIGUSR -merge=1 -merge_control_file=%t/MCF %t/C1 %t/C2  2>
>>> %t/log & export PID=$!
>>>  RUN: sleep 3
>>>  RUN: pkill -f -SIGUSR2 %t/LFSIGUSR
>>> +RUN: sleep 3
>>>  RUN: cat %t/log | FileCheck %s
>>>  RUN: grep C2/g %t/MCF
>>>  RUN: grep STARTED %t/MCF
>>>
>>> Modified: compiler-rt/trunk/test/fuzzer/sigusr.test
>>> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/f
>>> uzzer/sigusr.test?rev=317852&r1=317851&r2=317852&view=diff
>>> ============================================================
>>> ==================
>>> --- compiler-rt/trunk/test/fuzzer/sigusr.test (original)
>>> +++ compiler-rt/trunk/test/fuzzer/sigusr.test Thu Nov  9 16:26:23 2017
>>> @@ -6,6 +6,7 @@ RUN: %cpp_compiler %S/SleepOneSecondTest
>>>  RUN: %t/LFSIGUSR 2> %t/log & export PID=$!
>>>  RUN: sleep 2
>>>  RUN: kill -SIGUSR1 $PID
>>> +RUN: sleep 3
>>>  RUN: cat %t/log | FileCheck %s
>>>
>>>  CHECK: INFO: signal received, trying to exit gracefully
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171116/d3e1eee0/attachment.html>


More information about the llvm-commits mailing list