[PATCH] D39864: Fix for CFI type tests lowering assert.

Dmitry Mikulin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 16 13:02:29 PST 2017


dmikulin marked an inline comment as done.
dmikulin added inline comments.


================
Comment at: llvm/lib/IR/Value.cpp:459
 void Value::replaceUsesExceptBlockAddr(Value *New) {
+  SmallPtrSet<Constant *, 4> Constants;
   use_iterator UI = use_begin(), E = use_end();
----------------
davide wrote:
> SmallSetVector to make sure this is deterministic, maybe?
Not sure about the order, so changed it to SmallSetVector.


https://reviews.llvm.org/D39864





More information about the llvm-commits mailing list