[PATCH] D39473: [sanitizers] Increase alignment of low level allocator

Walter Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 16 08:29:34 PST 2017


waltl added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_allocator.cc:185
+  // Align allocation size.  Must be aligned to maximum supported
+  // shadow granularity.
+  size = RoundUpTo(size, 32);
----------------
vitalybuka wrote:
> Why can't this be just a shadow granularity?
It can, but I was not clear on how to get that value --
 SHADOW_GRANULARITY is defined in an asan header and I don't see any sanitizer_common sources including any asan headers.  And I'm not sure we wanted to move that to a sanitizer header.



https://reviews.llvm.org/D39473





More information about the llvm-commits mailing list