[PATCH] D40091: [AMDGPU] Add options for waitcnt pass debugging; add instr count in debug output.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 15 11:56:29 PST 2017


arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/SIInsertWaitcnts.cpp:1646
+      dbgs() << "Instr" << ++InstCnt << ": ";
       Inst.print(dbgs());
       ScoreBrackets->dump();
----------------
You can directly << the Inst, it doesn't need a separate print line


================
Comment at: test/CodeGen/AMDGPU/waitcnt-debug.mir:9
+...
+# CHECK-LABEL: name: waitcnt-debug
+# LGKM: S_WAITCNT 127
----------------
You don't add CHECK as a check-prefix, so this doesn't do anything


https://reviews.llvm.org/D40091





More information about the llvm-commits mailing list